wuchong commented on code in PR #20707:
URL: https://github.com/apache/flink/pull/20707#discussion_r963524735


##########
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java:
##########
@@ -41,16 +41,17 @@ public class JdbcCatalog extends AbstractJdbcCatalog {
     private final AbstractJdbcCatalog internal;
 
     public JdbcCatalog(
+            ClassLoader userClassLoader,

Review Comment:
   I'm afraid we can't modify the constructor because `JdbcCatalog` is 
annotated as `@PublicEvolving`. Can you add another constructor and deprecate 
the existing one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to