pnowojski commented on code in PR #20485:
URL: https://github.com/apache/flink/pull/20485#discussion_r965853207


##########
flink-core/src/main/java/org/apache/flink/api/common/eventtime/CombinedWatermarkStatus.java:
##########
@@ -95,10 +97,12 @@ public boolean updateCombinedWatermark() {
     static class PartialWatermark {
         private long watermark = Long.MIN_VALUE;
         private boolean idle = false;
+
+        @Nullable

Review Comment:
   If this is only used for the sake of tests, I would actually prefer to leave 
this field as non-null with no-op lambda functions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to