masteryhx commented on code in PR #20782:
URL: https://github.com/apache/flink/pull/20782#discussion_r966587453
##########
docs/content/docs/ops/metrics.md:
##########
@@ -1292,6 +1292,11 @@ Note that for failed checkpoints, metrics are updated on
a best efforts basis an
<td>The checkpointed size of the last checkpoint (in bytes), this metric
could be different from lastCheckpointFullSize if incremental checkpoint or
changelog is enabled.</td>
<td>Gauge</td>
</tr>
+ <tr>
Review Comment:
"rowspan" should also be modified so that the format of the table could be
showed correctly.
You could build the doc locally to check it.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTrackerTest.java:
##########
@@ -461,6 +467,7 @@ public <T, G extends Gauge<T>> G gauge(String name, G
gauge) {
assertEquals(Long.valueOf(persistedData),
latestPersistedData.getValue());
assertEquals(Long.valueOf(ackTimestamp),
latestCompletedDuration.getValue());
assertEquals(externalPath, latestCompletedExternalPath.getValue());
+ assertEquals(Long.valueOf(0), latestCompletedId.getValue());
Review Comment:
I think we could also check the correctness of checkpointId when failed and
in progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
