curcur commented on code in PR #20782:
URL: https://github.com/apache/flink/pull/20782#discussion_r970359887
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java:
##########
@@ -327,6 +327,9 @@ public void reportIncompleteStats(
static final String LATEST_COMPLETED_CHECKPOINT_EXTERNAL_PATH_METRIC =
"lastCheckpointExternalPath";
+ @VisibleForTesting
+ static final String LATEST_COMPLETED_CHECKPOINT_ID_METRIC =
"lastCheckpointId";
Review Comment:
To clarify why it has to specify "completed": failed cp also has an id,
`lastCheckpointId` can refer to a failed cp id, not necessarily a successful
id.
For other metrics, like full size or duration, it mostly make sense for
successful checkpoints.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java:
##########
@@ -327,6 +327,9 @@ public void reportIncompleteStats(
static final String LATEST_COMPLETED_CHECKPOINT_EXTERNAL_PATH_METRIC =
"lastCheckpointExternalPath";
+ @VisibleForTesting
+ static final String LATEST_COMPLETED_CHECKPOINT_ID_METRIC =
"lastCheckpointId";
Review Comment:
To clarify why it has to specify "completed": failed cp also has an id,
`lastCheckpointId` can refer to a failed cp id, not necessarily a successful
id.
For other metrics, like full size or duration, it mostly makes sense for
successful checkpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
