ganlute commented on code in PR #20542:
URL: https://github.com/apache/flink/pull/20542#discussion_r972711336
##########
flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseSinkFunction.java:
##########
@@ -213,6 +225,7 @@ public void close() throws Exception {
if (mutator != null) {
try {
+ flush();
Review Comment:
master:
close(){
...
mutator.close();
...
}
this pr:
close(){
...
flush();
mutator.close();
...
}
On the one hand, mutator.close will call mutator.flush as well. I think the
metioned problem will happen at master as well. On the other hand, If the
destination is down, mutator.close/mutator.flush will throw IOException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
