gyfora commented on code in PR #370:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r973754287
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -180,10 +180,6 @@ private Optional<String> validateJobSpec(
return Optional.empty();
}
- if (StringUtils.isNullOrWhitespaceOnly(job.getJarURI())) {
- return Optional.of("Jar URI must be defined");
- }
Review Comment:
You removed validation of JarURI for both FlinkDeployment and
FlinkSessionJob but at this moment the FlinkSessionJob still requires it
(otherwise I think we might get a NPE somewhere else). This is why I thought it
would be simplest to include the `no-op` jar changes also in this PR
cc @jeesmon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
