jeesmon commented on code in PR #370:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r974199626
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -180,10 +180,6 @@ private Optional<String> validateJobSpec(
return Optional.empty();
}
- if (StringUtils.isNullOrWhitespaceOnly(job.getJarURI())) {
- return Optional.of("Jar URI must be defined");
- }
Review Comment:
@gyfora @sap1ens What I did in our side was:
* Created a new maven module `flink-kubernetes-noop` to create a noop jar. I
believe Gyula had mentioned we may be able to use some maven magic to generate
this noop jar without adding another module, but I didn't invest time to look
at it yet. I was trying to keep this change separate with minimal diff from
upstream.
* Updated Dockerfile to copy noop jar to $FLINK_HOME/lib folder. We use a
different Dockerfile in our side as we have to use photon based base image.
As we are using helm to deploy FlinkSessionJob CR, I didn't make any
operator code change to use noop jar when jarURI is not present. Instead in
helm template of FlinkSessionJob I set jarURI to
`file:///opt/flink/lib/noop-0.0.1.jar` if jarURI is absent and entryClass is
present in values.yaml.
If the above path is still beneficial, I can create a PR. But please include
changes as part of this PR instead of what I outlined above if it fits better
with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
