pnowojski commented on code in PR #20852:
URL: https://github.com/apache/flink/pull/20852#discussion_r975206126
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java:
##########
@@ -218,13 +220,27 @@ CompletableFuture<String> triggerSavepoint(
final SavepointFormatType formatType,
@RpcTimeout final Time timeout);
+ /**
+ * Triggers taking a checkpoint of the executed job.
+ *
+ * @param checkpointProperties to determine how checkpoint should be taken
or null if the
+ * existing checkpoint property should be used
+ * @param timeout for the rpc call
+ * @return Future which is completed with the savepoint path once completed
+ */
+ CompletableFuture<CompletedCheckpoint> triggerCheckpoint(
Review Comment:
Good point. Indeed it would be better to not expose checkpoint location, but
just the checkpoint id. Checkpoints are owned by the system (contrary to the
savepoints, which are owned by the user), so user shouldn't be tempted to touch
checkpoint files. In this case, let's keep `CompletedCheckpoint`
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java:
##########
@@ -218,13 +220,27 @@ CompletableFuture<String> triggerSavepoint(
final SavepointFormatType formatType,
@RpcTimeout final Time timeout);
+ /**
+ * Triggers taking a checkpoint of the executed job.
+ *
+ * @param checkpointProperties to determine how checkpoint should be taken
or null if the
+ * existing checkpoint property should be used
+ * @param timeout for the rpc call
+ * @return Future which is completed with the savepoint path once completed
+ */
+ CompletableFuture<CompletedCheckpoint> triggerCheckpoint(
Review Comment:
Good point. Indeed it would be better to not expose checkpoint location, but
just the checkpoint id. Checkpoints are owned by the system (contrary to the
savepoints, which are owned by the user), so user shouldn't be tempted to touch
checkpoint files. In this case, let's keep `CompletedCheckpoint` as the return
type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
