stevenzwu commented on code in PR #20852: URL: https://github.com/apache/flink/pull/20852#discussion_r978880123
########## flink-core/src/main/java/org/apache/flink/core/execution/CheckpointBackupType.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.core.execution; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.configuration.DescribedEnum; +import org.apache.flink.configuration.description.InlineElement; + +import static org.apache.flink.configuration.description.TextElement.text; + +/** Describes the backup type in which a checkpoint should be taken. */ +@PublicEvolving +public enum CheckpointBackupType implements DescribedEnum { Review Comment: @leletan We probably don't need this enum at all and existing `CheckpointType` should we sufficient. There can be two triggering modes for checkpoint via REST endpoint. - `CHECKPOINT`: checkpoint is triggered based on the job configured checkpoint mode (incremental or full) - `FULL_CHECKPOINT`: checkpoint is triggered for full checkpoint regardless of the job config If in the future there is a need for triggering incremental checkpoint regardless of the job config, we can add a new enum value `INCREMENTAL_CHECKPOINT` to the existing `CheckpointType` later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
