[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #20875: (FLINK-29363) allow fully redirection in web dashboard

Wed, 21 Sep 2022 09:26:51 -0700 


gaborgsomogyi commented on code in PR #20875:
URL: https://github.com/apache/flink/pull/20875#discussion_r976740976


##########
flink-runtime-web/web-dashboard/src/app/app.interceptor.ts:
##########
@@ -39,6 +46,16 @@ export class AppInterceptor implements HttpInterceptor {
 
     return next.handle(req.clone({ withCredentials: true })).pipe(
       catchError(res => {
+        if (
+          res instanceof HttpResponseBase &&
+          (res.status == HttpStatusCode.MovedPermanently ||
+            res.status == HttpStatusCode.TemporaryRedirect ||
+            res.status == HttpStatusCode.SeeOther) &&

Review Comment:
   I've taken a look at the RFC and it lists multiple 3xx codes. Just wondering 
how did you picked the listed codes?
   <img width="550" alt="Screen Shot 2022-09-21 at 18 19 59" 
src="https://user-images.githubusercontent.com/18561820/191558022-abe65674-d545-4595-8cf4-6d6a1b06eabb.png";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to