[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #20875: [FLINK-29363][runtime-web] allow fully redirection in web dashboard

Fri, 23 Sep 2022 01:12:19 -0700 


gaborgsomogyi commented on code in PR #20875:
URL: https://github.com/apache/flink/pull/20875#discussion_r978376452


##########
flink-runtime-web/web-dashboard/src/app/app.interceptor.ts:
##########
@@ -39,6 +46,16 @@ export class AppInterceptor implements HttpInterceptor {
 
     return next.handle(req.clone({ withCredentials: true })).pipe(
       catchError(res => {
+        if (
+          res instanceof HttpResponseBase &&
+          (res.status == HttpStatusCode.MovedPermanently ||
+            res.status == HttpStatusCode.TemporaryRedirect ||
+            res.status == HttpStatusCode.SeeOther) &&

Review Comment:
   I was thinking about to add `302 Found` but that's optional which is denoted 
w/ the MAY keyword in the documentation:
   <img width="879" alt="Screen Shot 2022-09-23 at 10 10 44" 
src="https://user-images.githubusercontent.com/18561820/191918050-46b1acd5-9c0e-4dc4-ba8a-0928eb706800.png";>
   It's good as-is from my perspective.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to