usamj commented on code in PR #379:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/379#discussion_r977443276
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkService.java:
##########
@@ -66,14 +68,14 @@ public StandaloneFlinkService(
@Override
protected void deployApplicationCluster(JobSpec jobSpec, Configuration
conf) throws Exception {
LOG.info("Deploying application cluster");
- submitClusterInternal(conf, Mode.APPLICATION);
+ submitClusterInternal(conf, Mode.APPLICATION, Optional.of(jobSpec));
Review Comment:
Instead of passing the jobSpec through we should stick to the current model
of passing the args through conf.
In `FlinkConfigBuilder` we can take the args from the JobSpec and set them
to the flink config `kubernetes.jobmanager.entrypoint.args` (already exists).
This can then be accessed through the
`StandaloneKubernetesJobManagerParameters` in
`CmdStandaloneJobManagerDecorator` to add the args
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
