dannycranmer commented on code in PR #379:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/379#discussion_r977445727
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkService.java:
##########
@@ -115,7 +117,7 @@ protected FlinkStandaloneKubeClient
createNamespacedKubeClient(
executorService);
}
- private void submitClusterInternal(Configuration conf, Mode mode)
+ private void submitClusterInternal(Configuration conf, Mode mode,
Optional<JobSpec> jobSpec)
Review Comment:
We should use a `@Nullable` arg here instead of an Optional, as per Flink
[coding
standards](https://flink.apache.org/contributing/code-style-and-quality-java.html#java-optional)
##########
flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/decorators/CmdStandaloneJobManagerDecorator.java:
##########
@@ -85,6 +85,12 @@ private List<String> getApplicationClusterArgs() {
args.add(allowNonRestoredState.toString());
}
+ mainContainer.getArgs().stream()
+ .forEach(
+ arg -> {
+ args.add(arg);
+ });
+
return args;
Review Comment:
How about `args.addAll(mainContainer.getArgs())`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
