zentol commented on code in PR #111:
URL: https://github.com/apache/flink-shaded/pull/111#discussion_r979911314
##########
pom.xml:
##########
@@ -51,9 +51,23 @@ under the License.
<developerConnection>scm:git:https://github.com/apache/flink-shaded.git</developerConnection>
</scm>
+ <pluginRepositories>
+ <pluginRepository>
+ <!-- Allows exec-maven-plugin to resolve snapshot plugin
dependencies -->
+ <id>apache.snapshots.https</id>
+ <name>${distMgmtSnapshotsName}</name>
+ <url>${distMgmtSnapshotsUrl}</url>
+ </pluginRepository>
+ </pluginRepositories>
+
<properties>
<shading.prefix>org.apache.flink.shaded</shading.prefix>
<netty.version>4.1.70.Final</netty.version>
+ <!-- The license check requires the artifactId to match the directory
that the module resides in.
+ This is not the case for several modules in flink-shaded for
legacy reasons.
+ This property can be used by modules to add a suffix to the
artifactId to match the directory name on CI
+ when the 'license-check' profile is active. -->
+ <flink.ci.license.suffix/>
Review Comment:
This thing is super jank but I don't have an idea on how to solve it in
_general_ without potentially breaking _something_ (because we have to either
_add_ or _remove_ suffixes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
