zentol commented on code in PR #111:
URL: https://github.com/apache/flink-shaded/pull/111#discussion_r979915416
##########
pom.xml:
##########
@@ -51,9 +51,23 @@ under the License.
<developerConnection>scm:git:https://github.com/apache/flink-shaded.git</developerConnection>
</scm>
+ <pluginRepositories>
+ <pluginRepository>
+ <!-- Allows exec-maven-plugin to resolve snapshot plugin
dependencies -->
+ <id>apache.snapshots.https</id>
+ <name>${distMgmtSnapshotsName}</name>
+ <url>${distMgmtSnapshotsUrl}</url>
+ </pluginRepository>
+ </pluginRepositories>
+
<properties>
<shading.prefix>org.apache.flink.shaded</shading.prefix>
<netty.version>4.1.70.Final</netty.version>
+ <!-- The license check requires the artifactId to match the directory
that the module resides in.
+ This is not the case for several modules in flink-shaded for
legacy reasons.
Review Comment:
This is intentionally non-descriptive because frankly I don't see any logic
in which modules include a version in the artifactId.
For example, flink-shaded-asm-9 includes the major ASM version, which is
actually cool because you can depend on multiple flink-shaded-asm artifacts if
needed. But for some reason we don't allow that for guava.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
