alpinegizmo commented on code in PR #20930: URL: https://github.com/apache/flink/pull/20930#discussion_r984612707
########## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/OperatorIdentifier.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.state.api; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.runtime.jobgraph.OperatorID; +import org.apache.flink.state.api.runtime.OperatorIDGenerator; +import org.apache.flink.util.Preconditions; +import org.apache.flink.util.StringUtils; + +import javax.annotation.Nullable; + +import java.io.Serializable; +import java.util.Objects; +import java.util.Optional; + +/** Identifies an operator, either based on a {@code uid} or {@code uidHash}. */ +@Internal +public class OperatorIdentifier implements Serializable { + private final OperatorID operatorId; Review Comment: Maybe add a comment here explaining that the operatorID is the hashed ID? Because I'm not familiar with the OperatorID class, it took me a minute to figure out which id is which here. Or it might be enough to re-order the appearance of uid and uidHash in the comment above -- having them in the opposite order gave me pause as I tried to figure out which of operatorId and uid is the uidHash. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
