gyfora commented on code in PR #394:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/394#discussion_r991284849


##########
docs/content/docs/custom-resource/reference.md:
##########
@@ -251,6 +261,7 @@ This page serves as a full reference for FlinkDeployment 
custom resource definit
 | startTime | java.lang.String | Start time of the job. |
 | updateTime | java.lang.String | Update time of the job. |
 | savepointInfo | 
org.apache.flink.kubernetes.operator.crd.status.SavepointInfo | Information 
about pending and last savepoint for the job. |
+| jobHealthInfo | java.lang.String | Information about job health. |

Review Comment:
   Well we added this so technically we are free to add anything to it. 
Currently contains version info but we might as well put the health info there 
too. 
   
   This approach has 0 risk if we later want to change/remove the health info. 
Whereas if you introduce a new field to the CRD that is there to stay forever 
due to backward compatibility



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to