gaborgsomogyi commented on code in PR #394:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/394#discussion_r991402891
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -116,13 +116,10 @@ public void observe(FlinkDeployment flinkApp, Context<?>
context) {
}
private void observeClusterInfo(FlinkDeployment flinkApp, Configuration
configuration) {
- if (!flinkApp.getStatus().getClusterInfo().isEmpty()) {
- return;
- }
try {
Map<String, String> clusterInfo =
flinkService.getClusterInfo(configuration);
- flinkApp.getStatus().setClusterInfo(clusterInfo);
- logger.debug("ClusterInfo: {}", clusterInfo);
+ flinkApp.getStatus().getClusterInfo().putAll(clusterInfo);
Review Comment:
Important change that now we merge fetched info in order to keep previously
set health info or other upcoming things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
