twalthr commented on code in PR #20953:
URL: https://github.com/apache/flink/pull/20953#discussion_r991381438


##########
flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java:
##########
@@ -64,22 +64,37 @@
      *
      * <ul>
      *   <li>typeClass == atomic class (e.g. {@code Integer.class}) -> {@code 
ConfigOption<Integer>}
-     *   <li>typeClass == {@code Map.class} -> {@code ConfigOption<Map<String, 
String>>}
-     *   <li>typeClass == atomic class and isList == true for {@code 
ConfigOption<List<Integer>>}
+     *   <li>typeClass == atomic class and type == LIST for {@code 
ConfigOption<List<Integer>>}

Review Comment:
   @mxm Please do not touch the config stack without a full JIRA ticket and 
discussion! The current list of types and variations is well chosen and a list 
type is implicitly available. The parser syntax is also in sync with this 
behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to