snuyanzin commented on code in PR #20850:
URL: https://github.com/apache/flink/pull/20850#discussion_r993204783
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkAggregateExpandDistinctAggregatesRule.java:
##########
@@ -484,6 +488,7 @@ private void rewriteUsingGroupingSets(RelOptRuleCall call,
Aggregate aggregate)
false,
ImmutableIntList.copyOf(fullGroupSet),
-1,
+ ImmutableBitSet.of(),
Review Comment:
it seems like a bit gray area...
However I did a test with Calcite tests like what is the diff if I put
`null` or `ImmutableBitSet.of()` and some tests about parsing/dialect started
to fail because of generation `WITHIN ()`. So looks like it's better to have
null, also noticed that in javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
