snuyanzin commented on code in PR #20850:
URL: https://github.com/apache/flink/pull/20850#discussion_r993950327


##########
flink-table/flink-sql-parser-hive/pom.xml:
##########
@@ -56,6 +56,12 @@ under the License.
                        <artifactId>guava</artifactId>
                        <version>${guava.version}</version>
                        <scope>provided</scope>
+                       <exclusions>

Review Comment:
   for `flink-table-planner` `mvn dependency:tree` gives
   ```
   ...
   [INFO] +- org.apiguardian:apiguardian-api:jar:1.1.2:compile
   ...
   ```
   compile is expected because of 
`org.apache.calcite.sql.validate.SqlValidatorImpl` where there are some 
apiguardian's annotations
   
   for `flink-sql-parser` `mvn dependenc:tree` gives
   ```
   ...
   [INFO] +- org.junit.vintage:junit-vintage-engine:jar:5.8.1:test
   [INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.8.1:test
   [INFO] |  +- junit:junit:jar:4.13.2:test
   [INFO] |  \- org.apiguardian:apiguardian-api:jar:1.1.2:test
   ...
   ```
   
   fpr `flink-sql-parser-hive` `mvn dependency tree` gives
   ```
   ...
   [INFO] +- org.junit.vintage:junit-vintage-engine:jar:5.8.1:test
   [INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.8.1:test
   [INFO] |  +- junit:junit:jar:4.13.2:test
   [INFO] |  \- org.apiguardian:apiguardian-api:jar:1.1.2:test
   
   ...
   ```
   And neither jars from these 3 contains apiguardian



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to