[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516425#comment-15516425
]
ASF GitHub Bot commented on FLINK-4564:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80238976
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/MetricGroup.java
---
@@ -189,4 +189,15 @@
* @return fully qualified metric name
*/
String getMetricIdentifier(String metricName, CharacterFilter filter);
+
+ /**
+ * Returns the fully qualified metric name for reporter with certain
number position in group, for example
+ * {@code "host-7.taskmanager-2.window_word_count.my-mapper.metricName"}
+ *
+ * @param metricName metric name
+ * @param filter character filter which is applied to the scope
components if not null.
+ * @param indexReporter position number of reporter in group reporters
+ * @return fully qualified metric name
+ */
+ String getMetricIdentifier(String metricName, CharacterFilter
filter,int indexReporter);
--- End diff --
missing space after second comma.
> [metrics] Delimiter should be configured per reporter
> -----------------------------------------------------
>
> Key: FLINK-4564
> URL: https://issues.apache.org/jira/browse/FLINK-4564
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Anton Mushin
>
> Currently, the delimiter used or the scope string is based on a configuration
> setting shared by all reporters. However, different reporters may have
> different requirements in regards to the delimiter, as such we should allow
> reporters to use a different delimiter.
> We can keep the current setting as a global setting that is used if no
> specific setting was set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
