[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516421#comment-15516421
]
ASF GitHub Bot commented on FLINK-4564:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80239675
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -99,10 +99,17 @@ public MetricRegistry(Configuration config) {
DelegatingConfiguration reporterConfig = new
DelegatingConfiguration(config, ConfigConstants.METRICS_REPORTER_PREFIX +
namedReporter + ".");
final String className =
reporterConfig.getString(ConfigConstants.METRICS_REPORTER_CLASS_SUFFIX, null);
if (className == null) {
- LOG.error("No reporter class set for
reporter " + namedReporter + ". Metrics might not be exposed/reported.");
+ LOG.error("No reporter class set for
reporter {}. Metrics might not be exposed/reported.",namedReporter);
continue;
}
+ String delimiterForReporter =
reporterConfig.getString(ConfigConstants.METRICS_REPORTER_SCOPE_DELIMITER,defaultDelimiter);
+ if(delimiterForReporter.length()!=1){
+ LOG.warn("Failed to parse delimiter for
reporter {}, using global delimiter.",namedReporter);
--- End diff --
let's include the global delimiter in the message as well.
> [metrics] Delimiter should be configured per reporter
> -----------------------------------------------------
>
> Key: FLINK-4564
> URL: https://issues.apache.org/jira/browse/FLINK-4564
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Anton Mushin
>
> Currently, the delimiter used or the scope string is based on a configuration
> setting shared by all reporters. However, different reporters may have
> different requirements in regards to the delimiter, as such we should allow
> reporters to use a different delimiter.
> We can keep the current setting as a global setting that is used if no
> specific setting was set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
