sap1ens commented on PR #403: URL: https://github.com/apache/flink-kubernetes-operator/pull/403#issuecomment-1279584573
> I agree, it would be nice to have comprehensive tests that actually test the allowNonRestoredState logic. On the other hand if we simply enable that flag on existing tests at least we provide a regression test for this particular issue. > > Because current test would have still failed before this fix if that flag is enabled for standalone. Not quite: `allowNonRestoredState` is pretty much ignored unless `fromSavepoint` is also provided. WIth or without the boolean: it doesn't matter. That's why I think we need a real savepoint recovery test, probably as a separate issue / PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
