sap1ens commented on code in PR #403:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/403#discussion_r996348488
##########
flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/decorators/CmdStandaloneJobManagerDecorator.java:
##########
@@ -80,9 +80,14 @@ private List<String> getApplicationClusterArgs() {
}
Boolean allowNonRestoredState =
kubernetesJobManagerParameters.getAllowNonRestoredState();
- if (allowNonRestoredState != null) {
+ if (allowNonRestoredState != null && allowNonRestoredState) {
args.add("--allowNonRestoredState");
- args.add(allowNonRestoredState.toString());
+ }
+
+ String savepointPath =
kubernetesJobManagerParameters.getSavepointPath();
+ if (savepointPath != null) {
+ args.add("--fromSavepoint");
+ args.add(savepointPath);
Review Comment:
I thought about it too, but based on these lines:
-
https://github.com/apache/flink/blob/master/flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterEntryPoint.java#L95
-
https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java#L166-L168
it looks like if the flag is not present on the command-line, Flink will
override the value from the config file to `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
