wuchong commented on code in PR #21065:
URL: https://github.com/apache/flink/pull/21065#discussion_r999425716
##########
flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkWriterTest.java:
##########
@@ -101,6 +101,5 @@ void
getNumRecordsOutErrorsCounterRecordsCorrectNumberOfFailures()
.withMessageContaining(
"Unable to execute HTTP request: Connection refused:
localhost/127.0.0.1:443");
assertThat(ctx.metricGroup().getNumRecordsOutErrorsCounter().getCount()).isEqualTo(12);
-
assertThat(ctx.metricGroup().getNumRecordsSendErrorsCounter().getCount()).isEqualTo(12);
Review Comment:
Shall we keep the check? IIUC, the result of send error counter should be
equal to out error counter.
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java:
##########
@@ -139,21 +139,21 @@ public void testIncreasingRecordBasedCounters() throws
Exception {
try (final KafkaWriter<Integer> writer =
createWriterWithConfiguration(
getKafkaClientConfiguration(), DeliveryGuarantee.NONE,
metricGroup)) {
- final Counter numBytesSend = metricGroup.getNumBytesSendCounter();
- final Counter numRecordsSend =
metricGroup.getNumRecordsSendCounter();
- final Counter numRecordsWrittenErrors =
metricGroup.getNumRecordsOutErrorsCounter();
- final Counter numRecordsSendErrors =
metricGroup.getNumRecordsSendErrorsCounter();
- assertThat(numBytesSend.getCount()).isEqualTo(0L);
- assertThat(numRecordsSend.getCount()).isEqualTo(0);
- assertThat(numRecordsWrittenErrors.getCount()).isEqualTo(0);
- assertThat(numRecordsSendErrors.getCount()).isEqualTo(0);
+ final Counter numBytesOut =
metricGroup.getIOMetricGroup().getNumBytesOutCounter();
+ final Counter numRecordsOut =
metricGroup.getIOMetricGroup().getNumRecordsOutCounter();
+ final Counter numRecordsOutErrors =
metricGroup.getNumRecordsOutErrorsCounter();
+ final Counter numRecordsOutError =
metricGroup.getNumRecordsOutErrorsCounter();
Review Comment:
Duplicated counter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
