JingGe commented on code in PR #21065:
URL: https://github.com/apache/flink/pull/21065#discussion_r998006915
##########
flink-connectors/flink-connector-aws-kinesis-firehose/src/main/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkWriter.java:
##########
@@ -96,11 +96,7 @@ private static FirehoseAsyncClient createFirehoseClient(
RESOURCE_NOT_FOUND_EXCEPTION_CLASSIFIER,
getSdkClientMisconfiguredExceptionClassifier());
- // deprecated, use numRecordsSendErrorsCounter instead.
- @Deprecated private final Counter numRecordsOutErrorsCounter;
-
- /* A counter for the total number of records that have encountered an
error during put */
- private final Counter numRecordsSendErrorsCounter;
Review Comment:
They are using different counters:
https://github.com/apache/flink/blob/1902699cddcafcfabf9166d4221caa3545b60943/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSinkWriterMetricGroup.java#L48
BTW, removing it breaks the backward compatibility with 1.15.x too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
