JingsongLi commented on code in PR #328:
URL: https://github.com/apache/flink-table-store/pull/328#discussion_r1002982641


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/compact/LazyCompactManager.java:
##########
@@ -36,13 +38,25 @@ public boolean shouldWaitCompaction() {
     }
 
     @Override
-    public void addNewFile(DataFileMeta file) {}
+    public void addNewFile(DataFileMeta file) {
+        wrapped.addNewFile(file);
+    }
+
+    @Override
+    public void triggerCompaction(boolean fullCompaction) {
+        if (fullCompaction) {
+            wrapped.triggerCompaction(true);

Review Comment:
   We can throw unsupported exception here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to