JingsongLi commented on code in PR #328:
URL: https://github.com/apache/flink-table-store/pull/328#discussion_r1004006577
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/MergeTreeWriter.java:
##########
@@ -137,6 +137,11 @@ public void write(KeyValue kv) throws Exception {
}
}
+ @Override
+ public void compact() throws Exception {
Review Comment:
Can we just use `fullCompact`?
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/MergeTreeWriter.java:
##########
@@ -252,9 +257,9 @@ private void updateCompactResult(CompactResult result) {
compactAfter.addAll(result.after());
}
- private void submitCompaction() throws Exception {
- trySyncLatestCompaction(false);
- compactManager.triggerCompaction();
+ private void submitCompaction(boolean forcedCompaction) throws Exception {
Review Comment:
`forcedCompaction` -> `forcedFullCompaction`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
