wanglijie95 commented on code in PR #21111:
URL: https://github.com/apache/flink/pull/21111#discussion_r1005242107
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java:
##########
@@ -149,13 +159,45 @@ protected void startSchedulingInternal() {
super.startSchedulingInternal();
}
+ public boolean updateTaskExecutionState(TaskExecutionState
taskExecutionState) {
+ updateResultPartitionBytesMetrics(taskExecutionState.getIOMetrics());
Review Comment:
1, 2：Fixed.
3：This is indeed a problem. We can't clear the metric of a partition when it
is reset, because for `ALL_TO_ALL` results, we stores aggregated value. Given
that, I think we should only record the metric on the first finish, and let it
as the final value. @zhuzhurk WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
