Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2517#discussion_r80474552
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
 ---
    @@ -219,9 +249,16 @@ public ScopeFormats getScopeFormats() {
        public void register(Metric metric, String metricName, MetricGroup 
group) {
    --- End diff --
    
    if you change the signature to (Metric, String, AbstractMetricGroup) you 
would no longer need the cast on L257.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to