Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80499420
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -219,9 +249,16 @@ public ScopeFormats getScopeFormats() {
public void register(Metric metric, String metricName, MetricGroup
group) {
--- End diff --
In this case I get error in the compile for extending class of
MetricRegistry.
For example
org.apache.flink.runtime.metrics.groups.TaskMetricGroupTest.CountingMetricRegistry#register(Metric
, String , MetricGroup) and
org.apache.flink.runtime.metrics.groups.MetricGroupTest.ExceptionOnRegisterRegistry#register(Metric
, String , MetricGroup)
Cause by: method does not override or implement a method from a supertype
It is simple tests classes, I can change methods signature in their. But
will not be any problems in future because of this change in MetricRegistry?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
