XComp commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1005578991
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java:
##########
@@ -126,7 +126,7 @@ class ParquetColumnarRowInputFormatTest {
new MapType(new IntType(), new BooleanType()),
RowType.of(new VarCharType(VarCharType.MAX_LENGTH), new
IntType()));
- @TempDir private java.io.File folder;
Review Comment:
The hotfix commit does contain changes that are not related to the
`@Timeout` removal
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/avro/AvroParquetFileReadITCase.java:
##########
@@ -79,14 +92,14 @@ public static void setup() throws IOException {
createParquetFile(
AvroParquetWriters.forGenericRecord(schema),
-
Path.fromLocalFile(TEMPORARY_FOLDER.newFile(USER_PARQUET_FILE_1)),
+
Path.fromLocalFile(temporaryFolder.resolve(USER_PARQUET_FILE_1).toFile()),
Review Comment:
Aren't we creating a `Path` that's converted to a `File` for it to be
converted to a `Path` again? :thinking: ...this also applies to the other
occurrences below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
