ashmeet-kandhari commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1006431695
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java:
##########
@@ -79,7 +79,8 @@
*/
@SuppressWarnings("serial")
@RetryOnFailure(times = 3)
Review Comment:
Hi @snuyanzin
After going through the `RetryOnException` java docs it also mentions the
same thing
> Annotation to use with {@link org.apache.flink.testutils.junit.RetryRule}.
>
> <p>Add the {@link org.apache.flink.testutils.junit.RetryRule} to your test
class and annotate the
> class and/or tests with {@link RetryOnException}.
I also went through the `RetryExtension` source code and looks like it reads
from both the annotations (RetryOnException, RetryOnFailure)
Do you still think it makes sense to migrate to `RetryOnException`
annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
