ashmeet-kandhari commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1006434961
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationTest.java:
##########
@@ -38,16 +39,16 @@
* <p>For regenerating the binary snapshot files run {@link #writeSnapshot()}
on the corresponding
* Flink release-* branch.
*/
-@RunWith(Parameterized.class)
+@ExtendWith(ParameterizedTestExtension.class)
public class FlinkKafkaProducerMigrationTest extends KafkaMigrationTestBase {
- @Parameterized.Parameters(name = "Migration Savepoint: {0}")
+ @Parameters(name = "Migration Savepoint: {0}")
public static Collection<FlinkVersion> parameters() {
return FlinkVersion.rangeOf(FlinkVersion.v1_8, FlinkVersion.v1_15);
}
- public FlinkKafkaProducerMigrationTest(FlinkVersion testMigrateVersion) {
- super(testMigrateVersion);
- }
+ // public FlinkKafkaProducerMigrationTest(FlinkVersion
testMigrateVersion) {
+ // super(testMigrateVersion);
+ // }
Review Comment:
I wanted to check before I removed it.
Do you think we still need the constructor after migration to junit 5 or can
we remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
