salvalcantara commented on code in PR #21186:
URL: https://github.com/apache/flink/pull/21186#discussion_r1007919969
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java:
##########
@@ -491,6 +498,9 @@ private class DummyRecordSerializer implements
KafkaRecordSerializationSchema<In
@Override
public ProducerRecord<byte[], byte[]> serialize(
Integer element, KafkaSinkContext context, Long timestamp) {
+ if (element == null) {
+ return null;
+ }
return new ProducerRecord<>(topic,
ByteBuffer.allocate(4).putInt(element).array());
}
}
Review Comment:
Isn't this update of the current `testIncreasingRecordBasedCounters` case
enough for testing the change @MartijnVisser?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
