salvalcantara commented on code in PR #21186: URL: https://github.com/apache/flink/pull/21186#discussion_r1007933805
########## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java: ########## @@ -148,6 +148,13 @@ public void testIncreasingRecordBasedCounters() throws Exception { assertThat(numRecordsOutErrors.getCount()).isEqualTo(0); assertThat(numRecordsSendErrors.getCount()).isEqualTo(0); + // A null record is meaningless and should be skipped + writer.write(null, SINK_WRITER_CONTEXT); + assertThat(numBytesOut.getCount()).isEqualTo(0L); + assertThat(numRecordsOut.getCount()).isEqualTo(0); + assertThat(numRecordsOutErrors.getCount()).isEqualTo(0); + assertThat(numRecordsSendErrors.getCount()).isEqualTo(0); + Review Comment: Isn't this enough @MartijnVisser for testing the changes? I can consider a separate test for the null records exclusively but the existing `testIncreasingRecordBasedCounters` looks like a good spot to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org