libenchao commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r1009034445
########## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownPreparedStatementVisitor.java: ########## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.jdbc.table; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.table.expressions.CallExpression; +import org.apache.flink.table.expressions.Expression; +import org.apache.flink.table.expressions.ExpressionDefaultVisitor; +import org.apache.flink.table.expressions.FieldReferenceExpression; +import org.apache.flink.table.expressions.ResolvedExpression; +import org.apache.flink.table.expressions.ValueLiteralExpression; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.types.logical.LogicalType; + +import java.io.Serializable; +import java.math.BigDecimal; +import java.sql.Date; +import java.sql.Timestamp; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.util.List; +import java.util.Optional; +import java.util.function.Function; + +/** + * Visitor that convert Expression to ParameterizedPredicate. Return Optional.empty() if we cannot + * push down the filter. + */ +@Experimental +public class JdbcFilterPushdownPreparedStatementVisitor + extends ExpressionDefaultVisitor<Optional<ParameterizedPredicate>> { + + private Function<String, String> quoteIdentifierFunction; + + public JdbcFilterPushdownPreparedStatementVisitor( + Function<String, String> quoteIdentifierFunction) { + this.quoteIdentifierFunction = quoteIdentifierFunction; + } + + @Override + public Optional<ParameterizedPredicate> visit(CallExpression call) { + if (BuiltInFunctionDefinitions.EQUALS.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("=", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.LESS_THAN.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("<", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.LESS_THAN_OR_EQUAL.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("<=", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.GREATER_THAN.equals(call.getFunctionDefinition())) { + return renderBinaryOperator(">", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.GREATER_THAN_OR_EQUAL.equals(call.getFunctionDefinition())) { + return renderBinaryOperator(">=", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.NOT_EQUALS.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("<>", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.OR.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("OR", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.AND.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("AND", call.getResolvedChildren()); + } + + return Optional.empty(); + } + + private Optional<ParameterizedPredicate> renderBinaryOperator( + String operator, List<ResolvedExpression> allOperands) { + Optional<ParameterizedPredicate> leftOperandString = allOperands.get(0).accept(this); + + Optional<ParameterizedPredicate> rightOperandString = allOperands.get(1).accept(this); + + return leftOperandString.flatMap( + left -> rightOperandString.map(right -> left.combine(operator, right))); + } + + @Override + public Optional<ParameterizedPredicate> visit(ValueLiteralExpression litExp) { + LogicalType tpe = litExp.getOutputDataType().getLogicalType(); + Serializable[] params = new Serializable[1]; + + ParameterizedPredicate predicate = new ParameterizedPredicate("?"); + switch (tpe.getTypeRoot()) { Review Comment: 1. could you sort out the case branches, similar to `LogicalTypeRoot` 2. there are still some left types, such as `CHAR`, `SMALLINT`, `TINYINT`, I would suggest that we add these types as much as possible, unless we cannot for now. ########## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownPreparedStatementVisitor.java: ########## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.jdbc.table; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.table.expressions.CallExpression; +import org.apache.flink.table.expressions.Expression; +import org.apache.flink.table.expressions.ExpressionDefaultVisitor; +import org.apache.flink.table.expressions.FieldReferenceExpression; +import org.apache.flink.table.expressions.ResolvedExpression; +import org.apache.flink.table.expressions.ValueLiteralExpression; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.types.logical.LogicalType; + +import java.io.Serializable; +import java.math.BigDecimal; +import java.sql.Date; +import java.sql.Timestamp; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.util.List; +import java.util.Optional; +import java.util.function.Function; + +/** + * Visitor that convert Expression to ParameterizedPredicate. Return Optional.empty() if we cannot + * push down the filter. + */ +@Experimental +public class JdbcFilterPushdownPreparedStatementVisitor + extends ExpressionDefaultVisitor<Optional<ParameterizedPredicate>> { + + private Function<String, String> quoteIdentifierFunction; + + public JdbcFilterPushdownPreparedStatementVisitor( + Function<String, String> quoteIdentifierFunction) { + this.quoteIdentifierFunction = quoteIdentifierFunction; + } + + @Override + public Optional<ParameterizedPredicate> visit(CallExpression call) { + if (BuiltInFunctionDefinitions.EQUALS.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("=", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.LESS_THAN.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("<", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.LESS_THAN_OR_EQUAL.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("<=", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.GREATER_THAN.equals(call.getFunctionDefinition())) { + return renderBinaryOperator(">", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.GREATER_THAN_OR_EQUAL.equals(call.getFunctionDefinition())) { + return renderBinaryOperator(">=", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.NOT_EQUALS.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("<>", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.OR.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("OR", call.getResolvedChildren()); + } + if (BuiltInFunctionDefinitions.AND.equals(call.getFunctionDefinition())) { + return renderBinaryOperator("AND", call.getResolvedChildren()); + } + + return Optional.empty(); + } + + private Optional<ParameterizedPredicate> renderBinaryOperator( + String operator, List<ResolvedExpression> allOperands) { + Optional<ParameterizedPredicate> leftOperandString = allOperands.get(0).accept(this); + + Optional<ParameterizedPredicate> rightOperandString = allOperands.get(1).accept(this); + + return leftOperandString.flatMap( + left -> rightOperandString.map(right -> left.combine(operator, right))); + } + + @Override + public Optional<ParameterizedPredicate> visit(ValueLiteralExpression litExp) { + LogicalType tpe = litExp.getOutputDataType().getLogicalType(); + Serializable[] params = new Serializable[1]; + + ParameterizedPredicate predicate = new ParameterizedPredicate("?"); + switch (tpe.getTypeRoot()) { + case VARCHAR: + params[0] = litExp.getValueAs(String.class).orElse(null); + predicate.setParameters(params); + return Optional.of(predicate); + case BIGINT: + params[0] = litExp.getValueAs(Long.class).orElse(null); + predicate.setParameters(params); + return Optional.of(predicate); + case INTEGER: + params[0] = litExp.getValueAs(Integer.class).orElse(null); + predicate.setParameters(params); + return Optional.of(predicate); + case DOUBLE: + params[0] = litExp.getValueAs(Double.class).orElse(null); + predicate.setParameters(params); + return Optional.of(predicate); + case BOOLEAN: + params[0] = litExp.getValueAs(Boolean.class).orElse(null); + predicate.setParameters(params); + return Optional.of(predicate); + case FLOAT: + params[0] = litExp.getValueAs(Float.class).orElse(null); + predicate.setParameters(params); + return Optional.of(predicate); + case DECIMAL: + params[0] = litExp.getValueAs(BigDecimal.class).orElse(null); + predicate.setParameters(params); + return Optional.of(predicate); + case DATE: + params[0] = litExp.getValueAs(LocalDate.class).map(Date::valueOf).orElse(null); + predicate.setParameters(params); + return Optional.of(predicate); + case TIME_WITHOUT_TIME_ZONE: + params[0] = litExp.getValueAs(java.sql.Time.class).orElse(null); + predicate.setParameters(params); + return Optional.of(predicate); + case TIMESTAMP_WITHOUT_TIME_ZONE: + params[0] = + litExp.getValueAs(LocalDateTime.class).map(Timestamp::valueOf).orElse(null); + predicate.setParameters(params); + return Optional.of(predicate); + default: + return Optional.empty(); + } + } + + @Override + public Optional<ParameterizedPredicate> visit(FieldReferenceExpression fieldReference) { + String predicateStr = (this.quoteIdentifierFunction.apply(fieldReference.toString())); Review Comment: useless `(` `)` ########## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownPreparedStatementVisitor.java: ########## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.jdbc.table; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.table.expressions.CallExpression; +import org.apache.flink.table.expressions.Expression; +import org.apache.flink.table.expressions.ExpressionDefaultVisitor; +import org.apache.flink.table.expressions.FieldReferenceExpression; +import org.apache.flink.table.expressions.ResolvedExpression; +import org.apache.flink.table.expressions.ValueLiteralExpression; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.types.logical.LogicalType; + +import java.io.Serializable; +import java.math.BigDecimal; +import java.sql.Date; +import java.sql.Timestamp; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.util.List; +import java.util.Optional; +import java.util.function.Function; + +/** + * Visitor that convert Expression to ParameterizedPredicate. Return Optional.empty() if we cannot + * push down the filter. + */ +@Experimental +public class JdbcFilterPushdownPreparedStatementVisitor + extends ExpressionDefaultVisitor<Optional<ParameterizedPredicate>> { + + private Function<String, String> quoteIdentifierFunction; Review Comment: `final` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
