Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2540#discussion_r80612002
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -66,15 +67,16 @@
* <li>{@link #requestSlot(SlotRequest)} requests a slot from the
resource manager</li>
* </ul>
*/
-public class ResourceManager extends RpcEndpoint<ResourceManagerGateway>
implements LeaderContender {
+public abstract class ResourceManager<ResourceManagerGateway, WorkerType
extends TaskExecutorRegistration> extends RpcEndpoint implements
LeaderContender {
--- End diff --
@mxm , I adopt `ResourceManager<WorkerType extends TaskExecutorRegistration>
extends RpcEndpoint<ResourceManagerGateway> ` at first time, but it
would fail because of an Exception when I wanna to start a subClass of this
ResourceManager. For example, `public class StandaloneResourceManager extends
ResourceManager<TaskExecutorRegistration>`, when I start this ResourceManager,
it would call AkkaRpcService.#startServer, an exception would be thrown here
because selfGatewayType was mistake for TaskExecutorRegistration class. So I
change it to `ResourceManager<ResourceManagerGateway, WorkerType extends
TaskExecutorRegistration> extends RpcEndpoint`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
