Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2540
@mxm , thanks for your review, I modified the pr based on your advices:
1. fIx checkstyle error, `AkkaRpcActorTest` testcase and
`RpcCompletenessTest` testcase. Sorry for those mistakes, I would take care of
it next time.
2. About resourceManager, I adopt ResourceManager<WorkerType extends
TaskExecutorRegistration> extends RpcEndpoint<ResourceManagerGateway> at first
time, but it would fail because of an Exception when I wanna to start a
subClass of this ResourceManager. For example, public class
StandaloneResourceManager extends ResourceManager<TaskExecutorRegistration>,
when I start this ResourceManager, it would call AkkaRpcService.#startServer,
an exception would be thrown here because selfGatewayType was mistake for
TaskExecutorRegistration class. So I change it to
ResourceManager<ResourceManagerGateway, WorkerType extends
TaskExecutorRegistration> extends RpcEndpoint
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
