[
https://issues.apache.org/jira/browse/FLINK-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524850#comment-15524850
]
ASF GitHub Bot commented on FLINK-4606:
---------------------------------------
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2540#discussion_r80612002
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -66,15 +67,16 @@
* <li>{@link #requestSlot(SlotRequest)} requests a slot from the
resource manager</li>
* </ul>
*/
-public class ResourceManager extends RpcEndpoint<ResourceManagerGateway>
implements LeaderContender {
+public abstract class ResourceManager<ResourceManagerGateway, WorkerType
extends TaskExecutorRegistration> extends RpcEndpoint implements
LeaderContender {
--- End diff --
@mxm , I adopt `ResourceManager<WorkerType extends TaskExecutorRegistration>
extends RpcEndpoint<ResourceManagerGateway> ` at first time, but it
would fail because of an Exception when I wanna to start a subClass of this
ResourceManager. For example, `public class StandaloneResourceManager extends
ResourceManager<TaskExecutorRegistration>`, when I start this ResourceManager,
it would call AkkaRpcService.#startServer, an exception would be thrown here
because selfGatewayType was mistake for TaskExecutorRegistration class. So I
change it to `ResourceManager<ResourceManagerGateway, WorkerType extends
TaskExecutorRegistration> extends RpcEndpoint`
> Integrate the new ResourceManager with the existing FlinkResourceManager
> ------------------------------------------------------------------------
>
> Key: FLINK-4606
> URL: https://issues.apache.org/jira/browse/FLINK-4606
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: zhangjing
> Assignee: zhangjing
>
> Integrate the new ResourceManager with the existing FlinkResourceManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
