[
https://issues.apache.org/jira/browse/FLINK-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525181#comment-15525181
]
ASF GitHub Bot commented on FLINK-4606:
---------------------------------------
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2540
@mxm , thanks for your review, I modified the pr based on your advices:
1. fIx checkstyle error, `AkkaRpcActorTest` testcase and
`RpcCompletenessTest` testcase. Sorry for those mistakes, I would take care of
it next time.
2. About resourceManager, I adopt ResourceManager<WorkerType extends
TaskExecutorRegistration> extends RpcEndpoint<ResourceManagerGateway> at first
time, but it would fail because of an Exception when I wanna to start a
subClass of this ResourceManager. For example, public class
StandaloneResourceManager extends ResourceManager<TaskExecutorRegistration>,
when I start this ResourceManager, it would call AkkaRpcService.#startServer,
an exception would be thrown here because selfGatewayType was mistake for
TaskExecutorRegistration class. So I change it to
ResourceManager<ResourceManagerGateway, WorkerType extends
TaskExecutorRegistration> extends RpcEndpoint
> Integrate the new ResourceManager with the existing FlinkResourceManager
> ------------------------------------------------------------------------
>
> Key: FLINK-4606
> URL: https://issues.apache.org/jira/browse/FLINK-4606
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: zhangjing
> Assignee: zhangjing
>
> Integrate the new ResourceManager with the existing FlinkResourceManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
