elphastori commented on code in PR #21102:
URL: https://github.com/apache/flink/pull/21102#discussion_r1010278585
##########
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/DynamoDBStreamsProxy.java:
##########
@@ -110,6 +111,24 @@ public GetShardListResult getShardList(Map<String, String>
streamNamesWithLastSe
return result;
}
+ @Override
+ public String getShardIterator(
+ StreamShardHandle shard, String shardIteratorType, @Nullable
Object startingMarker)
+ throws InterruptedException {
+ try {
+ return super.getShardIterator(shard, shardIteratorType,
startingMarker);
+ } catch (ResourceNotFoundException re) {
+ if (LOG.isInfoEnabled()) {
Review Comment:
I agree, we risk polluting the logs for no value. Can have a comment here
instead to note that sometimes the API provides invalid shards?
```
// describeStream also returns shards that are no longer valid which need to
be marked as complete.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
