zentol commented on code in PR #21056:
URL: https://github.com/apache/flink/pull/21056#discussion_r1012914212
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -1174,6 +1161,16 @@ public void configure(ReadableConfig configuration,
ClassLoader classLoader) {
==
JobManagerOptions.SchedulerType.AdaptiveBatch));
}
+ @Internal
+ public <T> T get(ConfigOption<T> option) {
+ return configuration.get(option);
+ }
+
+ @Internal
+ public <T> Optional<T> getOptional(ConfigOption<T> option) {
+ return configuration.getOptional(option);
+ }
Review Comment:
hmm. Not quite sold on these yet. I see the long-term benefits of making a
switch to a plain `Configuration` easier, but I'm worried that someone will try
to use `getOptional` for an option that is never in the ExecutionConfig.
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -461,14 +461,20 @@ public RestartStrategies.RestartStrategyConfiguration
getRestartStrategy() {
}
}
+ /**
+ * TODO: this shouldn't exist and shouldn't pollute public API. Tests
should change this via
Review Comment:
This isn't too difficult to fix though, is it? Can't we modify the config
via the TableEnvironment in the affected tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
