zentol commented on code in PR #21056:
URL: https://github.com/apache/flink/pull/21056#discussion_r1013782333
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -1174,6 +1161,16 @@ public void configure(ReadableConfig configuration,
ClassLoader classLoader) {
==
JobManagerOptions.SchedulerType.AdaptiveBatch));
}
+ @Internal
+ public <T> T get(ConfigOption<T> option) {
+ return configuration.get(option);
+ }
+
+ @Internal
+ public <T> Optional<T> getOptional(ConfigOption<T> option) {
+ return configuration.getOptional(option);
+ }
Review Comment:
Are there more usages of these methods (or do we intend to add more)? Maybe
we don't need such a generic variant in the first place.
(maybe add a `isTaskCancellationTimeoutSet` method instead?)
Alternatively, maybe we could modify the ExecutionConfig post
deserialization on the TM side to contain the "final" execution config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
