[
https://issues.apache.org/jira/browse/FLINK-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526276#comment-15526276
]
ASF GitHub Bot commented on FLINK-4573:
---------------------------------------
GitHub user lw-lin opened a pull request:
https://github.com/apache/flink/pull/2556
[FLINK-4573] Fix potential resource leak due to unclosed RandomAccess…
…File in TaskManagerLogHandler
--
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lw-lin/flink raf-close
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2556
----
commit 8ec0dfae40c7b06e01e57260d16d6256f885f4e6
Author: Liwei Lin <[email protected]>
Date: 2016-09-27T12:49:52Z
[FLINK-4573] Fix potential resource leak due to unclosed RandomAccessFile
in TaskManagerLogHandler
----
> Potential resource leak due to unclosed RandomAccessFile in
> TaskManagerLogHandler
> ---------------------------------------------------------------------------------
>
> Key: FLINK-4573
> URL: https://issues.apache.org/jira/browse/FLINK-4573
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> {code}
> try {
> raf = new
> RandomAccessFile(file, "r");
> } catch
> (FileNotFoundException e) {
> display(ctx, request,
> "Displaying TaskManager log failed.");
> LOG.error("Displaying
> TaskManager log failed.", e);
> return;
> }
> long fileLength =
> raf.length();
> final FileChannel fc =
> raf.getChannel();
> {code}
> If length() throws IOException, raf would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
