[
https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528157#comment-15528157
]
ASF GitHub Bot commented on FLINK-4068:
---------------------------------------
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2560
[FLINK-4068] [table] Move constant computations out of code-generated
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
The origin PR is #2102. This PR makes `ReduceExpressionsRules` take effect.
This rule can reduce constant expressions and replacing them with the
corresponding constant.
And add some tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink reduce-expression-FLINK-4068
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2560.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2560
----
commit 22a0f2e949e524e20151c11cc83bd6e1e4f2a1b2
Author: Jark Wu <wuchong...@alibaba-inc.com>
Date: 2016-09-28T02:31:59Z
[FLINK-4068] [table] Move constant computations out of code-generated
----
> Move constant computations out of code-generated `flatMap` functions.
> ---------------------------------------------------------------------
>
> Key: FLINK-4068
> URL: https://issues.apache.org/jira/browse/FLINK-4068
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.1.0
> Reporter: Fabian Hueske
> Assignee: Jark Wu
>
> The generated functions for expressions of the Table API or SQL include
> constant computations.
> For instance the code generated for a predicate like:
> {code}
> myInt < (10 + 20)
> {code}
> looks roughly like:
> {code}
> public void flatMap(Row in, Collector<Row> out) {
> Integer in1 = in.productElement(1);
> int temp = 10 + 20;
> if (in1 < temp) {
> out.collect(in)
> }
> }
> {code}
> In this example the computation of {{temp}} is constant and could be moved
> out of the {{flatMap()}} method.
> The same might apply for generated function other than {{FlatMap}} as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
