[
https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529776#comment-15529776
]
ASF GitHub Bot commented on FLINK-4068:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2560#discussion_r80921875
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkRelBuilder.scala
---
@@ -38,7 +38,12 @@ class FlinkRelBuilder(
cluster,
relOptSchema) {
- def getPlanner: RelOptPlanner = cluster.getPlanner
+ def getPlanner: RelOptPlanner = {
+ val planner = cluster.getPlanner
+ // set the executor to evaluate constant expressions
+ planner.setExecutor(new
RexExecutorImpl(Schemas.createDataContext(null)))
--- End diff --
Why don't you use `FrameworkConfig.executor()` in `TableEnvironment` to set
the executor at the very beginning?
> Move constant computations out of code-generated `flatMap` functions.
> ---------------------------------------------------------------------
>
> Key: FLINK-4068
> URL: https://issues.apache.org/jira/browse/FLINK-4068
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.1.0
> Reporter: Fabian Hueske
> Assignee: Jark Wu
>
> The generated functions for expressions of the Table API or SQL include
> constant computations.
> For instance the code generated for a predicate like:
> {code}
> myInt < (10 + 20)
> {code}
> looks roughly like:
> {code}
> public void flatMap(Row in, Collector<Row> out) {
> Integer in1 = in.productElement(1);
> int temp = 10 + 20;
> if (in1 < temp) {
> out.collect(in)
> }
> }
> {code}
> In this example the computation of {{temp}} is constant and could be moved
> out of the {{flatMap()}} method.
> The same might apply for generated function other than {{FlatMap}} as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
