tisonkun commented on code in PR #21249:
URL: https://github.com/apache/flink/pull/21249#discussion_r1016472142
##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceOptions.java:
##########
@@ -204,6 +205,19 @@ private PulsarSourceOptions() {
"In this case, a single consumer
will still receive all the keys, but they may be coming in different orders.")
.build());
+ public static final ConfigOption<Boolean> PULSAR_ENABLE_SOURCE_METRICS =
+ ConfigOptions.key(SOURCE_CONFIG_PREFIX + "enableMetrics")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ Description.builder()
+ .text(
+ "We won't expose the metrics from
Pulsar Consumer if you disable this option.")
Review Comment:
```suggestion
"The metrics from Pulsar
Consumer are only exposed if you enable this option.")
```
Use positive statements instead of double negative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
