tisonkun commented on code in PR #21249:
URL: https://github.com/apache/flink/pull/21249#discussion_r1016479052
##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/PulsarSinkOptions.java:
##########
@@ -139,6 +140,19 @@ private PulsarSinkOptions() {
"The maximum number of pending
messages in one sink parallelism.")
.build());
+ public static final ConfigOption<Boolean> PULSAR_ENABLE_SINK_METRICS =
+ ConfigOptions.key(SINK_CONFIG_PREFIX + "enableMetrics")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ Description.builder()
+ .text(
+ "We won't expose the metrics from
Pulsar Producer if you disable this option.")
Review Comment:
```suggestion
"The metrics from Pulsar
Producer are only exposed if you enable this option.")
```
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
